Szelethus added a comment.

Actually, no. The main problem here is that `InnerPointerChecker` doesn't only 
want to register `MallocBase`, it needs to modify the checker object. In any 
case, either `MallocChecker.cpp` needs the definition of `InnerPointerChecker`, 
or vice versa. Sure, I could separate out the part that adds a new way to 
register dependencies, but it doesn't stop anyone from making the same mistake 
again, so what would be the point of that? I think it would be just a lot 
cleaner to split those checkers up properly, and completely replace the current 
system of registering checkers to stop anyone accidentally doing the same 
mistake again.


Repository:
  rC Clang

https://reviews.llvm.org/D54438



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to