ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clangd/TUScheduler.cpp:598 + if (!isCancelled(I->Ctx)) + continue; + // Cancelled reads are moved to the front of the queue and run immediately. ---------------- NIT: maybe also break on non-cancelled reads? Going past this point does not seem particularly useful, as we won't be able to cancel any pending updates before them anyway. And it does not seem like responding for a cancelled task fast is higher priority than delivering the results of that non-cancelled read. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54746 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
