sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clangd/ExpectedTypes.cpp:8 + +namespace clang { +namespace clangd { ---------------- nit: using namespace llvm (until/unless we switch other files) ================ Comment at: unittests/clangd/ExpectedTypeTest.cpp:33 +protected: + void build(llvm::StringRef Code) { + assert(!AST && "AST built twice"); ---------------- drop llvm:: here and below? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52273 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits