malaperle added a comment.
In https://reviews.llvm.org/D54781#1306102, @ioeric wrote:
> Could you run clang-format on the changed lines?
I didn't know clang-format could be used for Typescript. I ran it and it's a
bit inconsistent with the rest of the file but I don't want to format the whole
file.
================
Comment at: clangd/clients/clangd-vscode/package.json:81
+ "command": "clangd-vscode.switchheadersource",
+ "title": "C/C++: Switch between Source/Header"
+ }
----------------
ioeric wrote:
> and objc?
I just removed the languages. It's a bit much to have all of them.
================
Comment at: clangd/clients/clangd-vscode/src/extension.ts:55
protocol2Code: (value: string) =>
vscode.Uri.file(realpathSync(vscode.Uri.parse(value).fsPath))
}
----------------
ioeric wrote:
> We might want to share the logic for converting protocol URI to vscode URI.
What do you have in mind? I'm not sure there is much to share since I'm not
sure we should be using readpathSync for the toggle header/source. If the
source is opened as a symlink and the header also exists as a symlink then I
think it's OK to open the symlink.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54781
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
