pxli168 marked 4 inline comments as done.
================
Comment at: include/clang/Basic/Builtins.def:1255
@@ -1254,1 +1254,3 @@
+// OpenCL v2.0 s6.13.16, s9.17.3.5 -- Pipe functions.
+// We need the generic prototype, since the packet type could be anything.
----------------
Anastasia wrote:
> Could you remove one -?
Removed.
================
Comment at: lib/Sema/SemaChecking.cpp:291
@@ +290,3 @@
+ bool isValid = true;
+ // TODO: For all pipe built-in read is for read_only?
+ bool ReadOnly = getFunctionName(Call).find("read") != StringRef::npos;
----------------
Anastasia wrote:
> Why the TODO here?
TODO after get clarify from Khronos.
================
Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:36
@@ +35,3 @@
+ write_pipe(p, rid, rid, ptr); // expected-error {{invalid argument type to
function write_pipe (expecting: 'unsigned int')}}
+ write_pipe(p, tmp); // expected-error {{invalid argument type to function
write_pipe (expecting: 'int *')}}
+ read_pipe(p, ptr); // expected-error {{invalid pipe access modifier
(expecting read_only)}}
----------------
Anastasia wrote:
> remove : from error string
what do you mean by
> remove : from error string
http://reviews.llvm.org/D15914
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
