erichkeane added a comment.

This looks right to me.  Note the PTH removal is still waiting approval.



================
Comment at: include/clang/Basic/IdentifierTable.h:119
 
+  IdentifierInfo()
+      : TokenID(tok::identifier), ObjCOrBuiltinID(0), HasMacro(false),
----------------
Instead of putting these in an initializer, can you default-init each of them 
inline, then make this =default?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54866/new/

https://reviews.llvm.org/D54866



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to