This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347635: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking. (authored by henrywong, committed by ).
Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54878/new/ https://reviews.llvm.org/D54878 Files: clangd/AST.cpp Index: clangd/AST.cpp =================================================================== --- clangd/AST.cpp +++ clangd/AST.cpp @@ -95,11 +95,11 @@ return Out.str(); } // The name was empty, so present an anonymous entity. - if (llvm::dyn_cast<NamespaceDecl>(&ND)) + if (isa<NamespaceDecl>(ND)) return "(anonymous namespace)"; if (auto *Cls = llvm::dyn_cast<RecordDecl>(&ND)) return ("(anonymous " + Cls->getKindName() + ")").str(); - if (llvm::dyn_cast<EnumDecl>(&ND)) + if (isa<EnumDecl>(ND)) return "(anonymous enum)"; return "(anonymous)"; }
Index: clangd/AST.cpp =================================================================== --- clangd/AST.cpp +++ clangd/AST.cpp @@ -95,11 +95,11 @@ return Out.str(); } // The name was empty, so present an anonymous entity. - if (llvm::dyn_cast<NamespaceDecl>(&ND)) + if (isa<NamespaceDecl>(ND)) return "(anonymous namespace)"; if (auto *Cls = llvm::dyn_cast<RecordDecl>(&ND)) return ("(anonymous " + Cls->getKindName() + ")").str(); - if (llvm::dyn_cast<EnumDecl>(&ND)) + if (isa<EnumDecl>(ND)) return "(anonymous enum)"; return "(anonymous)"; }
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits