martong marked 4 inline comments as done. martong added inline comments.
================ Comment at: include/clang/AST/DeclContextInternals.h:125-129 + bool containsInVector(const NamedDecl *D) { + assert(getAsVector() && "Must have a vector at this point"); + DeclsTy &Vec = *getAsVector(); + return is_contained(Vec, D); + } ---------------- aaron.ballman wrote: > Given that this is only called in one place and is effectively a one-liner, > I'd get rid of this function entirely and replace the call below. Good catch, thank you. ================ Comment at: lib/AST/ASTImporter.cpp:2821 - Importer.MapImported(D, D2); ---------------- a_sidorin wrote: > Are these lines removed due to move of MapImported into Create helper? Yes, exactly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53655/new/ https://reviews.llvm.org/D53655 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits