congliu marked 9 inline comments as done. congliu added a comment. Fixed. For next steps, I will go through the results of clangmr, find out false alarms, and fix them.
================ Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:90 @@ +89,3 @@ + // Check ambiguity. + if (Paths.isAmbiguous(Context->getCanonicalType(BTy).getUnqualifiedType())) + return false; ---------------- alexfh wrote: > I wonder whether `BTy.getCanonicalType().getUnqualifiedType()` will work here. I'm afraid they're different. [[ http://clang.llvm.org/doxygen/classclang_1_1CXXBasePaths.html#a61341e71c248072b3f5bfbd54aea6174 | CXXBasePaths.isAmbiguous ]] receives a CanQualType parameter, while BTy.getCanonicalType().getUnqualifiedType() returns a QualType object. http://reviews.llvm.org/D15823 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
