ruiu accepted this revision.
ruiu added a comment.

LGTM. Please commit.

Peter, I wonder if you are fine with the default 64KiB page size with lld, 
especially given that lld always round up the text segment size to the maximum 
page size on disk and fill the padding with trap instructions. On average, that 
should increase the executable size by 32 KiB compared to other linkers. I 
don't think that size is necessarily bad, because we are doing that for a 
security purpose, but I wonder if people are OK with that.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55029/new/

https://reviews.llvm.org/D55029



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to