hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clangd/Quality.h:74
Keyword,
+ Operator,
} Category = Unknown;
----------------
Maybe name it `OverloadedOperator` to avoid confusion with other non-overloaded
operators like `?:`
================
Comment at: unittests/clangd/QualityTests.cpp:428
+
+TEST(QualityTests, OperatorQuality) {
+ auto Header = TestTU::withHeaderCode(R"cpp(
----------------
The test name `*Quality` is a bit confusing. At the first glance, I'd expect to
see some tests about ranking, but it just verifies that the new symbol category
is added, maybe name it something like `OperatorSymbolCategory`.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55061/new/
https://reviews.llvm.org/D55061
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
