martong added a comment. Hey Alexei,
Thank you again for your comments. I changed to code accordingly. Also, I recognized that we should use a `SmallSetVector` instead of a `SmallPtrSet`, because the latter results unpredictable iteration (pointers may have different values with each run). Though `SmallPtrSet` is more powerful than `SmallSetVector` it makes it really hard to debug false positive ODR warnings from the ASTImporter, because the warning may appear in one run but may not appear in the subsequent run. We need an iteration order in the order of insertions and that is produced by `SmallSetVector`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53708/new/ https://reviews.llvm.org/D53708 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
