probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM aside from a grump about the test, which is totally up to you.
================
Comment at: test/CodeGenCXX/debug-prefix-map-lambda.cpp:7
+ // CHECK: !DISubprogram(name: "b<(lambda at
+ // CHECK-SAME: /SOURCE_ROOT/debug-prefix-map-lambda.cpp
+ // CHECK-SAME: [[@LINE+1]]:{{[0-9]+}})>"
----------------
I've never liked tests that hard-code the test file name. FileCheck lets you
define variables on the RUN line, is there a lit substitution that will return
just the basename?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55137/new/
https://reviews.llvm.org/D55137
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
