kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clangd/FSProvider.cpp:33 + return File; + return std::unique_ptr<VolatileFile>( + new VolatileFile(std::move(std::move(*File)))); ---------------- make_unique? ================ Comment at: clangd/FSProvider.cpp:34 + return std::unique_ptr<VolatileFile>( + new VolatileFile(std::move(std::move(*File)))); + } ---------------- can we move once ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55139/new/ https://reviews.llvm.org/D55139 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
