martong added a comment.
> Also, almost everywhere CTU is capitalized, so I guess it should be in the
> field name too.
Ok, I renamed it to have CTU all capitalized.
================
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:239
+ if (DisplayCTUProgress) {
+ llvm::errs() << "ANALYZE (CTU loaded AST for source file): "
+ << ASTFileName << "\n";
----------------
a_sidorin wrote:
> I think we can remove parens from the message.
Ok, I removed the parens. And also changed the text from `CTU loaded AST for
source file` to `CTU loaded AST file` since we dump the path to the AST, not
the path to the source file from which we generated the AST file.
================
Comment at: test/Analysis/ctu-main.cpp:6
// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -analyze
-analyzer-checker=core,debug.ExprInspection -analyzer-config
experimental-enable-naive-ctu-analysis=true -analyzer-config ctu-dir=%T/ctudir
-verify %s
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -analyze
-analyzer-checker=core,debug.ExprInspection -analyzer-config
experimental-enable-naive-ctu-analysis=true -analyzer-config ctu-dir=%T/ctudir
-analyzer-display-ctu-progress 2>&1 %s | FileCheck %s
+
----------------
Szelethus wrote:
> I think these RUN lines would really benefit from introducing line breaks.
Yes, I agree. Unfortunately, I could not figure out how to break them. Using a
simple "\" at around the 80th column gives `Test has unterminated run lines
(with '\')`. If I use block comments with "\" the same happens. If I use block
comments and don't use the "\" then the second line is not interpreted. Is it
really possible to break RUN lines? I could not find anything about that in the
online docs.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55135/new/
https://reviews.llvm.org/D55135
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
