Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:31
+
+
+void AnonymousEnclosedAliasesCheck::check(const MatchFinder::MatchResult
&Result) {
----------------
Please remove unnecessary empty line.
================
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:33
+void AnonymousEnclosedAliasesCheck::check(const MatchFinder::MatchResult
&Result) {
+
+ const UsingDecl *MatchedUsingDecl =
----------------
Please remove unnecessary empty line.
================
Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:34
+
+ const UsingDecl *MatchedUsingDecl =
+ Result.Nodes.getNodeAs<UsingDecl>("using_decl");
----------------
const auto *
================
Comment at: clang-tidy/abseil/QualifiedAliasesCheck.cpp:13
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+
+#include <string>
----------------
Please remove unnecessary empty line.
================
Comment at: clang-tidy/abseil/SafelyScopedCheck.cpp:27
+ usingDecl(hasParent(namespaceDecl(forEach(namespaceDecl())))) )
+ ).bind("use"), this);
+}
----------------
Please run Clang-format over patch.
================
Comment at: docs/ReleaseNotes.rst:73
+
+ Flags using declarations in header files, and suggests that
+ these aliases be removed.
----------------
Please enclose using in ``. Same in other places, including documentation.
================
Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:10
+accept the specified alias. This is bad practice, which is why the check
suggests
+such declarations be removed.
----------------
Are there guidelines?
================
Comment at: docs/clang-tidy/checks/abseil-qualified-aliases.rst:24
+check.
+
----------------
Please remove unnecessary empty line.
================
Comment at: docs/clang-tidy/checks/abseil-safely-scoped.rst:28
+See https://abseil.io/tips/119 for more explanation.
+
----------------
Please remove unnecessary empty line.
================
Comment at: test/clang-tidy/abseil-qualified-aliases.cpp:27
+} // namespace example
+
----------------
Please remove unnecessary empty line.
================
Comment at: test/clang-tidy/abseil-safely-scoped.cpp:27
+} // namespace foo
+
----------------
Please remove unnecessary empty line.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55346/new/
https://reviews.llvm.org/D55346
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
