Eugene.Zelenko added inline comments.
================
Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:40
+void UseNodiscardCheck::registerMatchers(MatchFinder *Finder) {
+
+ // if we are using C++17 attributes we are going to need c++17
----------------
Unnecessary empty line.
================
Comment at: docs/ReleaseNotes.rst:173
+
+ Checks to detect if a member function looks like its return type should not
+ be ignored.
----------------
One sentence is enough for Release Notes. Will be good idea to make it same as
in documentation.
================
Comment at: docs/clang-tidy/checks/modernize-use-nodiscard.rst:40
+
+Users can use :option:`ReplacementString` to specify a macro to use instead of
+``[[nodiscard]]``. This is useful when maintaining source code that needs to
----------------
May be just this option?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55433/new/
https://reviews.llvm.org/D55433
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
