JonasToth added inline comments.
================ Comment at: clang-tidy/add_new_check.py:213 match = re.search('Improvements to clang-tidy', line) + match_next = re.search('Improvements to include-fixer', line) + match_checker = re.search('- New :doc:`(.*)', line) ---------------- I think it would be better to compile the regular expression and match with the compiled version. ================ Comment at: clang-tidy/add_new_check.py:218 + if last_checker > check_name_dashes: + add_note_here=True + ---------------- Please add whitespace around `=` ================ Comment at: clang-tidy/add_new_check.py:233 + + if header_found & add_note_here: if not line.startswith('----'): ---------------- what do you mean with the `&`? Is this intended as bit-operator? a `if header_found and add_note_here:` is better for logical expressions in python. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits