riccibruno added inline comments.
================ Comment at: lib/AST/Expr.cpp:1267 : Expr(SC, Empty), NumArgs(NumArgs) { + CallExprBits.UsesADL = false; CallExprBits.NumPreArgs = NumPreArgs; ---------------- riccibruno wrote: > I believe that msan can cope with bit level operations just fine. > What I am afraid is that initializing it here will hide the > fact that it is not initialized during deserialization if the > `E->setUsesADL(Record.readInt());` is removed by mistake. > > At least not initializing it here will leave a chance for msan > to catch this. I don't think they do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55534/new/ https://reviews.llvm.org/D55534 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits