martong marked 4 inline comments as done.
martong added inline comments.
================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:302
+/// is inspired by ASTContext::mergeFunctionTypes(), we compare calling
+/// conventions bits but must not compare some other bits, e.g. the noreturn
+/// bit.
----------------
shafik wrote:
> This comment is confusing b/c it looks like the noreturn bits are the only
> one you are not checking.
Ok, I have removed that part of the comment.
================
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:373
+TEST_F(StructuralEquivalenceFunctionTest,
+ FunctionsWithDifferentAttributesButSameTypesShouldBeEqual) {
----------------
shafik wrote:
> Can we get some more tests to be a little more thorough and can we also get a
> test where it is expected to to be false as well?
Ok, I have adder a few more tests and renamed the existing one.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53699/new/
https://reviews.llvm.org/D53699
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
