sbenza added inline comments. ================ Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:29 @@ +28,3 @@ + Class = Class.trim(); + return std::vector<std::string>(Classes.begin(), Classes.end()); +} ---------------- aaron.ballman wrote: > I think hasName() will assert if given an empty string, so this should > probably also guard against a class list like ",basic_string". Also changed the separator to be ';' instead of ','. The latter could be part of a type name. Eg. Foo<A,B>::Bar
http://reviews.llvm.org/D16152 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
