Szelethus added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:29 namespace { - struct RegionState { ---------------- Somewhat unrelated, but the size of this anonymous namespace is far too great. ================ Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:188-195 + void setAggressiveness(StringRef Str) { + Aggressiveness = + llvm::StringSwitch<AggressivenessKind>(Str) + .Case("KnownsOnly", AK_KnownsOnly) + .Case("KnownsAndLocals", AK_KnownsAndLocals) + .Case("All", AK_All) + .Default(AK_KnownsAndLocals); // A sane default. ---------------- You can acquire a `DiagnosticsEngine` through `ASTContext`, which can be acquired from `CheckerManager`. I think it'd prefer to see an error if I messed up the input. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55730/new/ https://reviews.llvm.org/D55730 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits