mgorny added reviewers: eugenis, kcc.
mgorny added a comment.

We've been discussing this, and I think we're doing this the wrong way. Could 
you help me a little understand this?

In particular, what is the purpose of unpoisoning file? Is it in order to 
account for stdio functions being implemented inline or as macros, and 
therefore user code accessing internal `FILE` members? Or is there some other 
use case for this?

If only the former, then I think there is no purpose in definining 
`__sanitizer_FILE` on NetBSD, as we support only reentrant interfaces which are 
all implemented as libc routine calls.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56109/new/

https://reviews.llvm.org/D56109



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to