mgorny marked an inline comment as done.
mgorny added inline comments.
================
Comment at: lib/esan/esan_interceptors.cpp:90
} while (false)
+#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file)
\
+ do {
\
----------------
krytarowski wrote:
> dvyukov wrote:
> > The idea behind defining a no-op version in
> > sanitizer_common_interceptors.inc was exactly that tools that are not
> > interested in it does not need to be changed. So please remove this.
> I would add an intermediate revision to drop redefinitions in this file.
@krytarowski, apparently it's not that simple. I've tried removing all the
empty definitions and now I get a lot of build errors ;-). It would probably be
necessary to take them one by one to establish which one are unnecessary after
all, and I don't think we have time for this right now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56157/new/
https://reviews.llvm.org/D56157
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
