jkorous added a comment.

Hi Alex, thanks for fixing this.

I assume chance of testing an Objective-C header with assignment to method 
result without any other specifically Objective-C (detectable) construct is 
significantly lower than chance of testing a C99 header with designated 
initializers. In other words - having potential for false Objective-C negatives 
in `parseSquare()` is probably fine given the context. Is that right?

If my assumption is correct I'd say LGTM unless anyone says otherwise within 1 
week.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56226/new/

https://reviews.llvm.org/D56226



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to