Quuxplusone added inline comments.

================
Comment at: lib/AST/TypePrinter.cpp:179
+    // `X<Some::Class>` gets canonicalized to `X<float, int>`. We disable
+    // canonicalization so that `printTag()`` can see the template parameters 
as
+    // written.
----------------
Nit: there's an extra ` on this line.

I think I vaguely understand the purpose of this switch now. It feels ugly, but 
I have no concrete suggestion for improvement. Do you not need a case here to 
delay canonicalization of `X<Some::Class>&` also?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55933/new/

https://reviews.llvm.org/D55933



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to