rafael added a comment. Thanks for working on this, but many of the changes setting the prefix to "_" look wrong.
================ Comment at: lib/Basic/Targets.cpp:801 @@ -818,2 +800,3 @@ LongDoubleFormat = &llvm::APFloat::PPCDoubleDouble; + UserLabelPrefix = "_"; } ---------------- This looks wrong, we produce a "f:" not an "_f:" when targeting powerpc-linux-gnu. ================ Comment at: lib/Basic/Targets.cpp:1617 @@ -1633,2 +1616,3 @@ GPU = GK_SM20; + UserLabelPrefix = "_"; } ---------------- This also looks wrong. ================ Comment at: lib/Basic/Targets.cpp:3659 @@ -3674,1 +3658,3 @@ + + UserLabelPrefix = "_"; } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:3991 @@ -4008,1 +3990,3 @@ + + UserLabelPrefix = "_"; } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:4530 @@ -4546,1 +4529,3 @@ + + UserLabelPrefix = "_"; } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:5308 @@ -5323,1 +5307,3 @@ + + UserLabelPrefix = "_"; } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:5834 @@ +5833,3 @@ + : TargetInfo(Triple), SoftFloat(false) { + UserLabelPrefix = "_"; + } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:6136 @@ -6147,2 +6135,3 @@ MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; + UserLabelPrefix = "_"; } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:6296 @@ -6306,2 +6295,3 @@ DataLayoutString = "e-m:e-p:16:16-i32:16:32-a:16-n8:16"; + UserLabelPrefix = "_"; } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:6393 @@ -6402,2 +6392,3 @@ UseAddrSpaceMapMangling = true; + UserLabelPrefix = "_"; } ---------------- This looks wrong. ================ Comment at: lib/Basic/Targets.cpp:6496 @@ -6504,2 +6495,3 @@ TheCXXABI.set(TargetCXXABI::GenericMIPS); + UserLabelPrefix = "_"; } ---------------- This looks wrong. http://reviews.llvm.org/D16295 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits