Elijah_Th marked 2 inline comments as done. Elijah_Th added a comment. What kind of wrapper should it be? I was thinking of this kind:
class ExtendedReplacement : public Replacement { public: ExtendedReplacement(StringRef CheckName, Replacement &R); StringRef getCheckName() const { return CheckName; } std::string CheckName; } but in this case (Replacement.h:141) typedef std::set<Replacement> Replacements; should be changed to typedef std::set<ExtendedReplacement> Replacements; which means a lot of code will be changed. Is that an acceptable change? Or you meant another kind of wrapper? http://reviews.llvm.org/D16183 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits