aaron.ballman added inline comments.
================
Comment at: lib/AST/ASTDumper.cpp:449-450
+ void VisitPackTemplateArgument(const TemplateArgument &TA) {
+ for (TemplateArgument::pack_iterator I = TA.pack_begin(),
+ E = TA.pack_end();
+ I != E; ++I)
----------------
steveire wrote:
> aaron.ballman wrote:
> > `llvm::for_each(TA.pack_elements(), ...);` (or a range-based for loop)
> I'm just moving the code as it is in its origin location. You could rewrite
> it separately if you wish.
I realize that. You're updating existing code, which is a perfectly appropriate
time for NFC improvements to it -- we make these kinds of requests frequently
because it's the time at which we notice these minor deficiencies.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55491/new/
https://reviews.llvm.org/D55491
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
