jlebar added a comment. Thank you for the review.
================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6418 @@ +6417,3 @@ +def warn_nvcc_compat_kern_is_method : Warning< + "kernel function %0 is a member function; this may not be accepted by nvcc">, + InGroup<CudaCompat>; ---------------- tra wrote: > There's an Extension<> tablegen class used to report various C and C++ > extensions. > This looks like a good use case for it. I'll also check that the rest of the CudaCompat warnings here shouldn't be Extension<>s. ================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6421 @@ +6420,3 @@ +def warn_nvcc_compat_kern_is_inlined : Warning< + "kernel function %0 is inlined; this may not be accepted by nvcc">, + InGroup<CudaCompat>; ---------------- tra wrote: > Perhaps we should use the same message as nvcc here: > 'inline qualifier ignored for "global" function' Ah, yes, given that it's not an nvcc error, we should just warn. (Or even not say anything at all; it seems like a silly warning.) http://reviews.llvm.org/D16261 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits