riccibruno marked 3 inline comments as done.
riccibruno added inline comments.
================
Comment at: include/clang/AST/Expr.h:5122
+ AssociationIteratorTy() = default;
+ AssociationTy<Const> operator*() const {
+ return AssociationTy<Const>(cast<Expr>(*E), *TSI,
----------------
aaron.ballman wrote:
> Can this continue to return `reference` instead of the concrete type? (Same
> in the cast expression.)
Not literally `reference` since the base is dependent, but `typename
BaseTy::reference` should work. Is that what you mean ?
================
Comment at: include/clang/AST/Expr.h:5254
+ /*Offset=*/NumAssocs, ResultIndex);
+ return {Begin, End};
}
----------------
aaron.ballman wrote:
> If you like being explicit, you could use `llvm::make_range()` here, but I
> don't insist. Same below.
I have no special preference on this, so `llvm::make_range()` it is.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57106/new/
https://reviews.llvm.org/D57106
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
