a_sidorin added a comment. Hi Gabor, Please find my comments inline.
================ Comment at: lib/CrossTU/CrossTranslationUnit.cpp:232 + + // We do not support CTU across languages (C vs C++). if (LangTo.CPlusPlus != LangFrom.CPlusPlus) { ---------------- The comment change looks strange. ================ Comment at: lib/CrossTU/CrossTranslationUnit.cpp:255 + LangTo.CPlusPlus2a != LangFrom.CPlusPlus2a) { + ++NumLangMismatch; + return llvm::make_error<IndexError>(index_error_code::lang_mismatch); ---------------- Should we create another counter, like NumLangDialectMismatch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57906/new/ https://reviews.llvm.org/D57906 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits