arphaman added inline comments.
================ Comment at: lib/Basic/FileManager.cpp:271 + } else if (!openFile) { + // Since we didn't return early after getStatValue() call the file exists. + fillRealPathName(&UFE, InterndFileName); ---------------- I don't really understand what this comment is trying to say. Can you rephrase it? ================ Comment at: unittests/Basic/FileManagerTest.cpp:349 +// rdar://problem/47536127 +TEST_F(FileManagerTest, getFileDontOpenRealPath) { ---------------- Please leave this comment out Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58213/new/ https://reviews.llvm.org/D58213 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits