It broke on the first commit and is broken even after all of them.

// Martin

On Fri, 15 Feb 2019, Yitzhak Mandelbaum wrote:

Was it the complete diff or one of the intermediate commits? I accidentally
committed the diff as a series of commits rather than one (squashed)
commit. 

On Fri, Feb 15, 2019 at 4:51 PM Martin Storsjö via Phabricator
<revi...@reviews.llvm.org> wrote:
      mstorsjo added a comment.

      This broke compilation with GCC 5.4 on Ubuntu 16.04:

       
      ../tools/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:474:243:
      warning: missing terminating " character
       
      ../tools/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:474:3:
      error: missing terminating " character
           EXPECT_TRUE(matches(
           ^
       
      ../tools/clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:480:7:
      error: stray ‘\’ in program
                 void z(X x) { x.m(); }
               ^


      Repository:
        rL LLVM

      CHANGES SINCE LAST ACTION
        https://reviews.llvm.org/D56850/new/

      https://reviews.llvm.org/D56850




_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to