kadircet added inline comments.
================
Comment at: lib/Index/IndexingContext.cpp:51
+
bool IndexingContext::handleDecl(const Decl *D,
SymbolRoleSet Roles,
----------------
ilya-biryukov wrote:
> kadircet wrote:
> > ilya-biryukov wrote:
> > > Do we call `handleDecl` for template parameters now too?
> > No we don't. I believe having the decl itself is not that useful for a
> > template parameter without a reference to it. We only call handlereference.
> I'm probably call both just for the sake of symmetry.
> How does `IndexParametersInDeclarations` behaves? When set to true will it
> call both `handleDecl` and `handleReference`?
> I'd argue we should do the same for template parameters.
yes it calls both, OK than adding also the `handleDecl`
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58293/new/
https://reviews.llvm.org/D58293
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
