shiva0217 added a comment.

In D57497#1394137 <https://reviews.llvm.org/D57497#1394137>, @efriedma wrote:

> > Did you mean declare as a target feature in RISCV.td or I misunderstanding 
> > something?
>
> That's sort of the right idea, but I don't think it works in this context 
> because we aren't trying to change the generated code for a function; we 
> actually need to stick the global into a specific section.  Maybe worth 
> sending an email to llvmdev to discuss the right way to represent this in IR?


Hi Eli,
I have sent the email to llvmdev 
http://lists.llvm.org/pipermail/llvm-dev/2019-February/130222.html. It seems 
that there're not much consensus on how to represent in IR. I incline to 
implement passing through `-plugin-opt=` as the first version. We could create 
an incremental patch when we have more consensus on IR approach. What do you 
think?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57497/new/

https://reviews.llvm.org/D57497



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D57497: [RISCV] Passing... Shiva Chen via Phabricator via cfe-commits

Reply via email to