dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land.
Looks good to me. I have some a minor diagnostic wording suggestion in line. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:109 + llvm::raw_svector_ostream OS(Str); + OS << "Deallocating object passed through parameter '" << PVD->getName() + << '\''; ---------------- Could we just have the note say "'name' is deallocated"? Or "Value passed through parameter 'name' is deallocated" The ".. is ... " construction matches our other checkers. (Like "Memory is released" from the Malloc Checker.) ================ Comment at: clang/test/Analysis/mig.mm:52 +kern_return_t release_twice(mach_port_name_t port, vm_address_t addr1, vm_address_t addr2, vm_size_t size) { + kern_return_t ret = KERN_ERROR; // expected-note{{'ret' initialized to 1}} + vm_deallocate(port, addr1, size); // expected-note{{Deallocating object passed through parameter 'addr1'}} ---------------- A nice QoI improvement here (for a later patch, perhaps) would be to have this note use the macro name: "'ret initialized to KERN_ERROR'". Users probably won't know that KERN_ERROR is 1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58368/new/ https://reviews.llvm.org/D58368 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits