dexonsmith added a comment. In D58548#1407355 <https://reviews.llvm.org/D58548#1407355>, @dexonsmith wrote:
> In D58548#1407331 <https://reviews.llvm.org/D58548#1407331>, @greened wrote: > > > +1. Is there any reason not to use "%4" in the definition? > > > > define i32 @f(i32, i32) { > > %3 = add i32 %0, %1 > > br label %4 > > > > %4: > > ret i32 %3 > > } > > > > > > Maybe it creates an ambiguity in the grammar or something. > > > A `%` isn't used for labels that do have names, so David's approach seems > consistent. s/David/James/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58548/new/ https://reviews.llvm.org/D58548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits