smeenai accepted this revision.
smeenai added a comment.
LGTM, thanks!
================
Comment at: clang/lib/Headers/CMakeLists.txt:136
list(APPEND out_files ${dst})
+ # The list function only updates out_files in the current scope. We need
+ # call set in order to also update the variable for the parent's scope.
----------------
I don't think this comment is necessary – this is a pretty common CMake
pattern, and I think the PARENT_SCOPE is enough of a search hint for people who
aren't familiar with it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58537/new/
https://reviews.llvm.org/D58537
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
