vsk added a comment.

I'm confused by this wording re: comdats in the LangRef: "All global objects 
that specify this key will only end up in the final object file if the linker 
chooses that key over some other key". Why can multiple global objects with the 
same comdat key end up in the final object file?

Also, why is the selection kind here 'any' instead of 'exactmatch'? If the 
counter array sizes legitimately can vary (why?), then wouldn't we want 
'largestsize'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58737/new/

https://reviews.llvm.org/D58737



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to