teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
I think the idea of the patch is right. Not sure tough if having Import take a
second parameter is consistent with the other Import functions (and if that
even matters).
================
Comment at: include/clang/AST/ASTImporter.h:340
/// context, or the import error.
llvm::Expected<FileID> Import_New(FileID);
// FIXME: Remove this version.
----------------
Import_New should probably also get the new paramater.
================
Comment at: include/clang/AST/ASTImporter.h:342
// FIXME: Remove this version.
- FileID Import(FileID);
+ FileID Import(FileID, bool isBuiltin=false);
----------------
`IsBuiltin`, not `isBuiltin`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58743/new/
https://reviews.llvm.org/D58743
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
