pgousseau marked an inline comment as done. pgousseau added inline comments.
================ Comment at: include/clang/Basic/Sanitizers.h:29 +class hash_code; +} ---------------- riccibruno wrote: > What ? You are forward-declaring `hash_code` here and using it as a value a > few lines later. Just include `llvm/ADT/Hashing.h`. Thanks for reviewing! I am happy to include `Hashing.h` but I thought it was generally frown upon to add includes if avoidable? `hash_code` is only used in the return type of the `hash_value()` declaration here no? I saw StringRef.h or APInt.h also forward declare `hash_code`. Thanks again for reviewing and sorry for the many iterations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
