whisperity added inline comments.
================ Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:49 + "NoDiagnoseCallsToSystemHeaders", + "", + "false"> ---------------- Let's put at least a FIXME here that the documentation for this option was missing. ================ Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:907 + "TrackNSCFStartParam", + "", + "false"> ---------------- Same here for missing documentation/description for optstring. ================ Comment at: lib/Frontend/CompilerInvocation.cpp:425 bool HasFailed = getStringOption(Config, Name, std::to_string(DefaultVal)) - .getAsInteger(10, OptionField); + .getAsInteger(0, OptionField); if (Diags && HasFailed) ---------------- What is this trying to do? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
