george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land.
I think that addresses all of the concerns people have put forward; given rnk's comment about one more round of fixes, this LGTM. Will check this in for you shortly. Thanks again! ================ Comment at: clang/utils/creduce-clang-crash.py:1 +#!/usr/bin/env python +# A tool that calls C-Reduce to create a minimal reproducer for clang crashes ---------------- thakis wrote: > rnk wrote: > > george.burgess.iv wrote: > > > nit: please specify a python version here, since the world is steadily > > > making `python` == `python3` (if `pipes.quote` is working, I assume > > > you'll want `#!/usr/bin/env python2`) > > Please don't do that, there is no python2.exe or python3.exe on Windows. > > `#!/usr/bin/env python` is the simplest thing that could work. > There's no python2 on mac either. `#!/usr/bin/env python` is the correct > first line for executable python scripts. TIL. Thank you both for the counterexamples :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
