erichkeane marked an inline comment as done. erichkeane added inline comments.
================ Comment at: lib/Sema/SemaDecl.cpp:3144 + << FunctionType::getNameForCallConv(NewTypeInfo.getCC()) + << 3 /*on builtin function*/; + NewTypeInfo = NewTypeInfo.withCallingConv(OldTypeInfo.getCC()); ---------------- rnk wrote: > You can make these self-documenting with an enum, and then reference the enum > name in a comment in the .td file. It seems the existing convention is to put > these types of enums directly into the Sema class. Ah, great! I didn't realize there was a convention for how to do these. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59560/new/ https://reviews.llvm.org/D59560 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
