efriedma added inline comments.
================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:574
+ if (ArgTy->getElementType()->isFloatingPointTy()) {
+ auto fArgs = F->getFunctionType()->params();
+ Type *Tys[] = {fArgs[0], fArgs[1]};
----------------
This code is weird... you're computing the types in two different ways. Also,
missing a check for F->arg_size() (so we don't crash on invalid IR).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59655/new/
https://reviews.llvm.org/D59655
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
