RKSimon added inline comments.
================ Comment at: lib/Headers/ia32intrin.h:31 +static __inline__ int __attribute__((__always_inline__, __nodebug__)) +__bsfd(int __A) { ---------------- Ideally we'd have doxygen comments. ================ Comment at: test/CodeGen/bitscan-builtins.c:24 +// CHECK: @test__bsfd +// CHECK: %[[call:.*]] = call i32 @llvm.cttz.i32( + return __bsfd(X); ---------------- Should we be testing the is_zero_undef flag is true? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59682/new/ https://reviews.llvm.org/D59682 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits