Anastasia marked an inline comment as done.
Anastasia added inline comments.


================
Comment at: include/clang/Basic/DiagnosticLexKinds.td:397
+def ext_pp_opencl_variadic_macros : Extension<
+  "variadic macros not supported in OpenCL">;
 
----------------
arsenm wrote:
> Maybe rephrase the message now to say it's an extension? The other similar 
> warnings seem to mention "GNU extension" or "Microsoft extensions" or 
> <standard version> extension.
> 
> None of them seem to mention "clang" extensions however.
Actually I have found a couple of diagnostics with Clang extension so it should 
be fine.

Thanks for the feedback.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59492/new/

https://reviews.llvm.org/D59492



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to