akhuang added inline comments.
================ Comment at: clang/utils/creduce-clang-crash.py:212 + + cmd = self.get_crash_cmd() + ['-E', '-P'] + try: ---------------- arichardson wrote: > Some crash messages might include the line numbers, do you think it makes > sense to fall back to running with -E but without -P and also checking that? > I do it in my script but I'm not sure preprocessing saves that much time > since creduce will try to remove those statements early. Makes sense-- in my experience preprocessing is still quite a bit faster than letting creduce remove all the statements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/ https://reviews.llvm.org/D59725 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
