aaron.ballman added inline comments.
================ Comment at: include/clang/Basic/Attr.td:293 bit Negated = negated; + string CustomCode = customCode; } ---------------- I think the type here should be `code` instead of `string` since the user is passing in code snippets, no? ================ Comment at: lib/Sema/SemaDeclObjC.cpp:4129-4130 + + if (IntfDecl->hasAttr<ObjCClassStubAttr>()) { + if (!IntfDecl->hasAttr<ObjCSubclassingRestrictedAttr>()) + Diag(IntfDecl->getLocation(), diag::err_class_stub_subclassing_mismatch); ---------------- Combine these `if` statements? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59628/new/ https://reviews.llvm.org/D59628 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits